fix: retain original request in middleware handler #1919
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
=======================================
Coverage 76.06% 76.06%
=======================================
Files 20 20
Lines 1496 1496
Branches 233 233
=======================================
Hits 1138 1138
Misses 351 351
Partials 7 7 ☔ View full report in Codecov by Sentry. |
IdanLupinskyMyPorsche
force-pushed
the
main
branch
2 times, most recently
from
af76362 to
e3aff9a
Compare
|
lgtm |
arpit-jn
previously approved these changes
Feb 18, 2025
|
Hey @IdanLupinskyMyPorsche, these changes look fine but we cannot merge this PR unless your commit |
IdanLupinskyMyPorsche
force-pushed
the
main
branch
from
770de96 to
9e3f97f
Compare
we noticed that custom headers from the original request were not retained as `NextResponse.next` was called without the original request
IdanLupinskyMyPorsche
force-pushed
the
main
branch
3 times, most recently
from
0203b02 to
36673df
Compare
|
pushed verified commit. |
IdanLupinskyMyPorsche
force-pushed
the
main
branch
2 times, most recently
from
f9cea0e to
36673df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we noticed that custom headers from the original request were not retained as
NextResponse.nextwas called without the original request📋 Changes
This should be a fix to allow the original request to be retained when passed through the middleware. We require this to retain a custom header in the original request.
📎 References
🎯 Testing
As you can see we updated one of the tests handling a "no matching auth route" to see that the
NextResponse.nextwas called with the original NextRequest. In particular, we tested that the request passed is the same using a spy.